cdo/regex-engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Assert success of alloc in deep_copy_* loops

Browse Source 
Returning false here would leave the destination sequence in an
invalid state and may lead to leaked memory; until this is solved
properly it is safer to assert().
This commit is contained in:
Camden Dixie O'Brien 2024-10-26 19:15:17 +01:00
parent ecfbf2e5c4
commit 3a578e190f
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/desugar.c
View File

@ -46,10 +46,8 @@ static bool deep_copy_sequence(parse_sequence_t *dst, parse_sequence_t *src)
if (NULL == dst->contents)
return false;
for (int i = 0; i < dst->count; ++i) {
if (!deep_copy_term(&dst->contents[i], &src->contents[i]))
return false;
}
for (int i = 0; i < dst->count; ++i)
assert(deep_copy_term(&dst->contents[i], &src->contents[i]));
return true;
}
@ -68,9 +66,8 @@ static bool deep_copy_term(parse_term_t *dst, parse_term_t *src)
return false;
for (int i = 0; i < dst->subexpr.count; ++i) {
if (!deep_copy_sequence(
&dst->subexpr.contents[i], &src->subexpr.contents[i]))
return false;
assert(deep_copy_sequence(
&dst->subexpr.contents[i], &src->subexpr.contents[i]));
}
}